Fix hardware acceleration flag for Linux

[Revival8697]

Fix hardware acceleration flag for Linux

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

#961, already closed but issue still present.
#4526

Description

Screenshots

Here is the Before-After if the pull request is implemented as flags.

Before:

After:

Testing

Tested working (on my machine).
Test builds are available here.

Desktop

• OS: Arch Linux
• OS Version: Rolling release 2024-01-08
• FreeTube version: https://github.com/FreeTubeApp/FreeTube/actions/runs/7440373756

Additional context

[Revival8697]

app.commandLine.appendSwitch('use-gl', 'angle')
app.commandLine.appendSwitch('use-angle', 'gl')

These two lines are not needed when tested but I included them because Chromium Docs said so.

You can remove them if they are enabled by default (by Chromium/Electron) or already implemented somewhere else.

Seems like they are, on Linux. I will remove them.

[absidue]

Did you test on Windows and macOS too before removing the existing flags?

If not please only add the new ones and stick them inside an if, so they only apply on Linux where they are needed.

[Revival8697]

Did you test on Windows and macOS too before removing the existing flags?

Those flags are all deprecated. They do nothing.

#ignore-gpu-blacklist is now #ignore-gpu-blocklist but it is not really FreeTube's job to decide if it should bypass the blocklist. User can make that choice themselves or ask to remove their GPU from the blocklist.

You can add it back if you still decide to keep it.

The flag doesn't seem to cause any issue on Windows.

I can not test on MacOS since I do not own the hardware.

[Revival8697]

If not please only add the new ones and stick them inside an if, so they only apply on Linux where they are needed.

Electron doesn't seem to have a native way to detect OS, there are examples/modules on the Internet but as I'm not very familiar with Electron, I will not attempt to do it.

If you deem it necessary to have such function, you can instruct me on how it should be done or find someone else to do it.

[kommunarr]

LGTM (tested with intel-gpu-tools like in the OP).