Fix the local API about tab for channels without a joined date #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kommunarr
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
LGTM. Notes for others:
- You'll need to run
yarnagain if you can't replicate this issue / see the joined tag at all. Took me a couple of minutes to realize that. - This (probably) can't be replaced with just a truthy check because it's using a custom Youtube.js type of
Text, not a string.
ChunkyProgrammer
approved these changes
Jan 2, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the local API about tab for channels without a joined date
Pull Request Type
Description
Currently the local API errors when it tries to extract the about tab for channels that don't have a joined date, like the official
@YouTubechannel.Testing
Visit the official
@YouTubechannel and check that no local API error shows up (the shorts duration parsing error logs will be fixed in a separate pull request)https://www.youtube.com/channel/UCBR8-60-B28hp2BmDPdntcQ
Desktop