Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale files so yaml parsing won't cause errors (Part 2) #3546

Conversation

ChunkyProgrammer
Copy link
Member

Fix locale files so yaml parsing won't cause errors (Part 2)

Pull Request Type

  • Bugfix

Related issue

#3522

Description

Fix locale yaml files so weblate can parse them

Testing

See #3527

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 14, 2023 23:55
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 14, 2023
@absidue
Copy link
Member

absidue commented May 15, 2023

I suspect this will just keep coming back until it's either fixed on the weblate side or we manually rip out all empty strings, so that weblate can't do it and break it.

@PikachuEXE
Copy link
Collaborator

Looking at commit 40d5259
I think this might be caused by webplate trying to convert

Videos:
  #& Sort By
  Sort By:
    Oldest: ''
    #& Most Popular
#& Playlists

into

Videos: {}

but somehow bugged into

Videos:
  #& Sort By
{}

So let's remove those and see if the same thing happens again

@ChunkyProgrammer
Copy link
Member Author

I suspect this will just keep coming back until it's either fixed on the weblate side or we manually rip out all empty strings, so that weblate can't do it and break it.

Should we ask Preston to disable the weblate plugin to delete empty values?

@FreeTubeBot FreeTubeBot merged commit adaa830 into FreeTubeApp:development May 17, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 17, 2023
@ChunkyProgrammer ChunkyProgrammer deleted the try-to-fix-weblate-update branch August 15, 2023 19:19
@ChunkyProgrammer ChunkyProgrammer mentioned this pull request Oct 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants