Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut: Home key to go to beginning of video #2745

Conversation

Pistos
Copy link

@Pistos Pistos commented Oct 18, 2022

Add Home shortcut

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Relates to (but does not close) #2138

Description

Adds an alternate hotkey for going to the beginning of the current video. (Existing hotkey is the 0 key, for going to the 0% point of the video (1 for 10%, etc.))

Screenshots

None

Testing

I have tested it manually. I did not find a test suite or side-by-side .spec.js files or anything.

Desktop

  • OS: Linux
  • OS Version: Kernel version 5.10.52
  • FreeTube version: Development branch, as of commit a6b86fa

Additional context

None needed

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 18, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 18, 2022 20:49
@efb4f5ff-1298-471a-8973-3d47447115dc

Hi there,

Thankyou for opening this PR. Unfortunately all missing shortcuts including this one are already being addressed in #2698 and is almost ready to be merged.

Because of that i will close this PR. Hopefully this won't discourage u in addressing other issues in our repo :)

auto-merge was automatically disabled October 18, 2022 22:04

Pull request was closed

@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 18, 2022
@Pistos
Copy link
Author

Pistos commented Oct 19, 2022

That's fine, it was low effort anyway. :) And, I see that Vue is used in this codebase, and that's my favourite web framework. I might contribute other PRs in the future. Thanks for the quick response, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants