Playlist page improvements #2281
Conversation
There was a problem hiding this comment.
Please fix the missing new lines at the end of the files and the share menu getting cut off.
Playlist in the screenshots: https://www.youtube.com/playlist?list=PLDIoUOhQQPlXr63I_vwF9GD8sAKh77dWU
Share menu in development:
Normal with this PR:
Hovering over the share menu with this PR:
Head branch was pushed to by a user without write access
…into feature/playlist-improvements
|
@absidue yeahhhh, you can scroll and see them but it's not ideal agreed. Going to need a hot second to figure out a good solution. EDIT: I've pushed a bandaid fix that I think is fine for now but will be removed once I get around to cleaning up some of the main layout styling in the app (the margins everywhere make positioning and sizing a nightmare) |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
styling has been a problem for a long time see #856 :( |
…list-improvements
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Originally, when this overflow-y was added, the share playlist dropdown went straight down, so there would no need for the content to be able to overflow in the y direction. (FreeTubeApp#2281) Now, the dropdown swings out to the left by default, and even when it is centered, it still overflows the width of the container as an intentional part of the design.
* Set share playlist dropdown position to `center` w/ media query * Remove overflow-y as it causes the overflow issue Originally, when this overflow-y was added, the share playlist dropdown went straight down, so there would no need for the content to be able to overflow in the y direction. (#2281) Now, the dropdown swings out to the left by default, and even when it is centered, it still overflows the width of the container as an intentional part of the design. * Remove unnecessary whitespace
Playlist page improvements
Pull Request Type
Please select what type of pull request this is:
Related issue
Closes #2255
Description
Small love and care to the playlist templates:
Screenshots (if appropriate)
Please add before and after screenshots if there is a visible change.
Before:
After:
Testing (for code that is not small enough to be easily understandable)
Just played around with playlists and smaller views.
Desktop (please complete the following information):