Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage tests for Kernel PR 1203 #1315

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Conversation

aggarg
Copy link
Member

@aggarg aggarg commented Dec 19, 2024

Description

Fix coverage tests for Kernel PR FreeRTOS/FreeRTOS-Kernel#1203.

Test Steps

Run coverage tests.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

FreeRTOS/FreeRTOS-Kernel#1203

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PR Link - FreeRTOS/FreeRTOS-Kernel#1203.

Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
@jasonpcarroll
Copy link
Member

Please fix failing unit tests.

Copy link
Member

@AniruddhaKanhere AniruddhaKanhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aggarg the suggested changes should fix the tests.

…covg_multiple_priorities_no_timeslice_mock_utest.c
…covg_multiple_priorities_no_timeslice_mock_utest.c
@AniruddhaKanhere
Copy link
Member

@aggarg, do we also need to update the submodule of the Kernel?

Copy link
Member

@jasonpcarroll jasonpcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update submodule pointer for the FreeRTOS-Kernel

…ce_mock/covg_multiple_priorities_no_timeslice_mock_utest.c"

This reverts commit 83a211d.
…ce_mock/covg_multiple_priorities_no_timeslice_mock_utest.c"

This reverts commit e342ac2.
Copy link
Member

@jasonpcarroll jasonpcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the notion that this needs to merge before updating the submodule pointer

@aggarg aggarg merged commit 93ba585 into FreeRTOS:main Dec 20, 2024
23 of 25 checks passed
@aggarg aggarg deleted the cov_test_pr_1203 branch December 20, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants