Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the minimal example #823

Merged
merged 8 commits into from
Oct 14, 2023
Merged

Added the minimal example #823

merged 8 commits into from
Oct 14, 2023

Conversation

n9wxu
Copy link
Member

@n9wxu n9wxu commented Oct 9, 2023

Description

minimal build example

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@n9wxu n9wxu requested a review from a team as a code owner October 9, 2023 14:59
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2be332a) 93.66% compared to head (c873de9) 93.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #823   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files           6        6           
  Lines        2526     2526           
  Branches      604      604           
=======================================
  Hits         2366     2366           
  Misses        107      107           
  Partials       53       53           
Flag Coverage Δ
unittests 93.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n9wxu
Copy link
Member Author

n9wxu commented Oct 9, 2023

/bot run formatting

Copy link
Member Author

@n9wxu n9wxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a newline

aggarg
aggarg previously approved these changes Oct 10, 2023
@Skptak
Copy link
Member

Skptak commented Oct 10, 2023

In general I am confused what the minimal_freertos_example/main.c file. To me it seems like an objectively worse version of the Posix_GCC/main.c, the WIN32-MSVC-Static-Allocation-Only, the WIN32-MSVC, or the WIN32-MingW main.c files?

@n9wxu
Copy link
Member Author

n9wxu commented Oct 12, 2023

/bot run formatting

@amazonKamath
Copy link
Member

amazonKamath commented Oct 13, 2023

In general I am confused what the minimal_freertos_example/main.c file. To me it seems like an objectively worse version of the Posix_GCC/main.c, the WIN32-MSVC-Static-Allocation-Only, the WIN32-MSVC, or the WIN32-MingW main.c files?

I understand this is a minimal "build" example, than an example demonstrating functionality.

@Skptak
Copy link
Member

Skptak commented Oct 13, 2023

In general I am confused what the minimal_freertos_example/main.c file. To me it seems like an objectively worse version of the Posix_GCC/main.c, the WIN32-MSVC-Static-Allocation-Only, the WIN32-MSVC, or the WIN32-MingW main.c files?

I understand this is a minimal "build" example, than an example demonstrating functionality.

But if it's a "minimal build example" it should be called that, or contain that information.
This file directly states:
/* This is a simple main that will start freertos and run a periodic task */

In my opinion, if the only reason this file exists is for static analysis it should probably just live in .github directory. If it's meant to be a true sample main.c file it should have info that would help a new user use it and turn it into an actual main.c file

@Skptak
Copy link
Member

Skptak commented Oct 13, 2023

/bot run formatting

archigup
archigup previously approved these changes Oct 13, 2023
@n9wxu
Copy link
Member Author

n9wxu commented Oct 13, 2023

/bot run formatting

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@n9wxu n9wxu merged commit 1b2b090 into FreeRTOS:main Oct 14, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants