Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configASSERT default definition above before including portable.h. #1185

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

ActoryOu
Copy link
Member

@ActoryOu ActoryOu commented Nov 4, 2024

Move configASSERT default definition above before including portable.h.

Description

As #1170 mentioned, for RP2040 port, there is a compile error if users don't define configASSERT in FreeRTOSConfig.h.
In this PR, we move the configASSERT default definition above before including portable.h to solve this problem in a generic method.

Test Steps

  1. Remove configASSERT definition in FreeRTOS/Test/Target/boards/pico/FreeRTOSConfig.h.
  2. Updating Kernel submodule pointer to the working forked branch.
  3. Compile RP2040 target testing load.
  4. Pass compilation.
export PICO_SDK_PATH=$PATH_TO_PICO_SDK
rm -fr $PATH_TO_FREERTOS/FreeRTOS/FreeRTOS/Test/Target/boards/pico/build
cd $PATH_TO_FREERTOS/FreeRTOS/FreeRTOS/Test/Target/boards/pico
export FREERTOS_KERNEL_PATH=$PATH_TO_FREERTOS/FreeRTOS/FreeRTOS/Source
cmake -S . -B build
cd build
make -j

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ActoryOu ActoryOu requested a review from a team as a code owner November 4, 2024 08:42
Copy link

sonarqubecloud bot commented Nov 4, 2024

@aggarg aggarg merged commit a27d665 into FreeRTOS:main Nov 4, 2024
16 checks passed
@ActoryOu ActoryOu deleted the MoveAssertDefine branch November 4, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants