Fix for numvalues parameter in Node.read_raw_history() #1351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the function FreeOpcUa / opcua-asyncio / asyncua / common / node.py / read_raw_history() declares that non-zero
numvalues
parameter should truncate the amount of historical data to receive from a server:Actually,
numvalues
parameter is practically useless and has no effect on the function behavior. The function always reads and returns full set of historical information as defined by the other parameters regardless ofnumvalues
value.This pull request eliminates the inconsistence between the function declaration and actual behavior. If the pull request applied, the function asks for the limited amount of historical data from a server (as requested by non-zero
numvalues
parameter). It makes it possible to effectively control RAM usage of client side without guessing right period of time for historical data to request.Please, note:
So, the client is free to decide if it wants to request the rest of historical data from ContinuationPoint or not.
The pull request was created as a continuation of this issue. Tested against 3rd party OPC UA server.