Fix NodeId parsing for nodes containing semicolons in string identifiers

Example:
The node `ns=9;s=Line1.nsuri=MACHINE.NS;s=MACHINE.NS.State.Running` is regularly deconstructed as NamespaceId `9`, Identifier Type `String`, Identifier `Line1.nsuri=MACHINE.NS;s=MACHINE.NS.State.Running`. Previously this was parsed to have the Identifier `MACHINE.NS.State.Running`

asyncua/ua/uatypes.py

@@ -531,7 +531,8 @@ def _from_string(string):
         ntype = None
         srv = None
         nsu = None
-        for el in elements:
+        while elements:
+            el = elements.pop(0)  # consume exactly one part of the node name, left-to-right
             if not el:
                 continue
             k, v = el.split("=", 1)
@@ -543,7 +544,11 @@ def _from_string(string):
                 identifier = int(v.strip())
             elif k == "s":
                 ntype = NodeIdType.String
-                identifier = v
+                # As per https://reference.opcfoundation.org/Core/Part3/v105/docs/8.2.4 and https://reference.opcfoundation.org/Core/Part3/v104/docs/8.2.4,
+                # strings may contain arbitrary non-control unicode characters, even semicolons and equals.
+                # We must now consume the whole rest of the identifier.
+                identifier = String(";".join((v, *elements)))
+                elements = []  # consume everything immediately
             elif k == "g":
                 ntype = NodeIdType.Guid
                 identifier = uuid.UUID(f"urn:uuid:{v}")

tests/test_common.py

@@ -14,6 +14,7 @@
 from pathlib import Path
 from base64 import b64encode
 import pytest
+from asyncua.ua import NodeId, String, NodeIdType, Int16
 
 from asyncua import Node, ua, uamethod
 from asyncua.common import ua_utils
@@ -2097,3 +2098,10 @@ async def test_sql_injection():
     table = "user'"
     with pytest.raises(SqlInjectionError) as _:
         validate_table_name(table)
+
+
+async def test_parse_nodeid_name_contains_multiple_dividers():
+    raw_node_name = "ns=9;s=Line1.nsuri=MACHINE.NS;s=MACHINE.NS.State.Running"
+    expected_node_id = NodeId(Identifier=String("Line1.nsuri=MACHINE.NS;s=MACHINE.NS.State.Running"), NamespaceIndex=Int16(9), NodeIdType=NodeIdType.String)
+    got_node_id = NodeId.from_string(string=raw_node_name)
+    assert got_node_id == expected_node_id