Add supports for importing a folder with trailing slash on the path #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we will always append
/index.js
to the folder path when we import a directory index.js file, for example:It will be problematic when we serve the files and load it in browser, for example, say we have following folder structure:
./src/index.js
./src/Foo/index.js
./src/Bar.js
now we serve the
src
folder onhttp://localhost:8080
and loadhttp://localhost:8080/index.js
in browser:./src/index.js
file, syntaximport Foo from './Foo/';
becomesimport Foo from './Foo//index.js';
and thenhttp://localhost:8080/Foo//index.js
, this will work, but then../Bar.js
by the URLhttp://localhost:8080/Foo/Bar.js
, this won't work, we will get 404 error.This PR attempts to fix the issue by simply check whether the path does ends with trailing slash.