-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose install function #518
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/lsvrf6au9 |
I'm not sure if i need to add https://www.npmjs.com/package/@pika/plugin-build-types, because
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this as a starting point, but with an "unstable" prefix:
export {install as unstable_installCommand} from './commands/install';
Even though we won't document this on snowpack.dev, we still want to make sure that someone who does find it knows that it's not officially supported and could change across even patch versions, until we get further along in the work outlined in #312 and feel comfortable maintaining via semver)
@jlkiri If you can make that change, I'll merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We actually might need to prioritize a true install JS API sooner rather than later for #475
In this PR I simply expose the
install
function without any modifications.Related issues: #312