Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ETag to file responses #410

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Add ETag to file responses #410

merged 1 commit into from
Jun 2, 2020

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Jun 2, 2020

Part 1 of #404

This adds an ETag header for each file we send from the server.

The only thing I'm not sure on is if we should specify the Weak option or not.

@FredKSchott
Copy link
Owner

I think it's fine without weak option for now. I hadn't even heard of that before, so TIL.

LGTM

@FredKSchott FredKSchott merged commit 3da9016 into FredKSchott:master Jun 2, 2020
@stramel stramel deleted the ms/add-etag-to-file-response branch June 2, 2020 09:34
@stramel stramel mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stramel @FredKSchott