Exclude protogen from code coverage reports #3151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMcM
reviewed
Feb 13, 2025
| @@ -85,7 +85,8 @@ tasks.register('codeCoverageReport', JacocoReport) { | |||
| def exclusions = [ | |||
| "**/*Proto.class", "**/*Proto\$*.class", | |||
| "**/planprotos/*", "**/eventprotos/*", | |||
| "**/generated/*", "**/grpc/v1/**/*" | |||
| "**/generated/*", "**/grpc/v1/**/*", | |||
| "**/protogen/*" | |||
There was a problem hiding this comment.
These are class / package names, not build source directory names. What classes have protogen in their package name?
There was a problem hiding this comment.
Ha! In that case, this won't work.
This is from com.apple.foundationdb.relational.continuation.
Basically the classes defined in https://github.com/FoundationDB/fdb-record-layer/blob/main/fdb-relational-core/src/main/proto/continuation.proto
There was a problem hiding this comment.
I guess there isn't anything more distinctive than the class name itself. Though perhaps renaming it to have Proto in it would be worth considering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.