addressing previous comments in metrics in explain #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecgrieser
requested changes
Feb 10, 2025
| final long expectedMetric = (long)expected.getField(fieldDescriptor); | ||
| final long actualMetric = (long)actual.getField(fieldDescriptor); | ||
| if (expectedMetric != actualMetric) { | ||
| logger.warn("‼️ metric {} differs; lineNumber = {}; expected = {}; actual = {}", |
There was a problem hiding this comment.
Any reason this isn't using a KeyValueLogMessage?
| @@ -3,9 +3,9 @@ agg-index-tests-count-empty: | |||
| explain: 'AISCAN(MV1 <,> BY_GROUP -> [_0: VALUE:[0]]) | MAP (_ AS _0) | ON EMPTY | |||
| NULL | MAP (coalesce_long(_._0._0, promote(0l AS LONG)) AS _0)' | |||
| task_count: 434 | |||
| task_total_time_ms: 13 | |||
| task_total_time_ms: 19 | |||
There was a problem hiding this comment.
Does this PR need to update all of the checked in metrics? It we can avoid doing it, it would be nice just to avoid churn on these files if it's not needed
There was a problem hiding this comment.
Yes -- there was a mistake int the previous PR that it also kept metrics for explainContains: which causes problems for downstream tests.
There was a problem hiding this comment.
So I am recreating all metrics here since I don't want any of the explainContains: metrics to be kept at all.
alecgrieser
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.