-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test-summary action with custom action code #3119
Open
ScottDugas
wants to merge
13
commits into
FoundationDB:main
Choose a base branch
from
ScottDugas:action-test-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottDugas
force-pushed
the
action-test-output
branch
from
February 7, 2025 20:47
85d9cd8
to
2f2d62f
Compare
ScottDugas
force-pushed
the
action-test-output
branch
from
February 7, 2025 22:05
2f2d62f
to
18a2577
Compare
I think publishing on the gradle step itself may have messed with the standard gradle summary
ScottDugas
force-pushed
the
action-test-output
branch
from
February 10, 2025 13:07
18a2577
to
a9ee2fa
Compare
I thought more than one worked, but nope...
I'm hoping this will cause it to run even if it failed, as long as the file exists.
ScottDugas
changed the title
Action test output
Replace test-summary action with custom action code
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test-summary action takes the xml files produced by the tests, but our xml files in the nightly action get too large for the action to load them as a string (~540mb), due to all the logging.
This replaces the test-summary action with built-in steps that print to
GITHUB_STEP_SUMMARY
. They use the listener to gather the test results and exceptions.You can see two examples of PRBs with the resulting output. Both of these disable many of the tests so that I could iterate more quickly:
I think there's two followups that could be nice, but decided not to do them right now:
destructiveTest
runs from the summary that have 0 tests in them, which would make that table much smaller.