Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Facebook & Pinterest logos #4463

Closed
tylertrotter opened this issue Sep 17, 2014 · 8 comments
Closed

Update Facebook & Pinterest logos #4463

tylertrotter opened this issue Sep 17, 2014 · 8 comments

Comments

@tylertrotter
Copy link

In the attached image I've set a Font Awesome Facebook icon (left) next to one I pulled from Facebook's website (right). You can see that the rounded corners and proportions of the square are both off.

facebook-icons

@tagliala
Copy link
Member

@tylertrotter this is for uniformity with other squared icons in FA

@athyuttamre
Copy link

@tagliala This violates brand guidelines though. If we're not using the right Facebook logo, it looks rather unpolished. Would be really nice to use the right one. Thoughts?

Here's the brand guideline: www.facebookbrand.com.

@davegandy davegandy changed the title Facebook icon is slightly off Update Facebook & Pinterest logos Dec 12, 2014
@davegandy
Copy link
Member

This one has always bugged me. In 4.3, we’ll have 3 versions:
fa-facebook (official)
fa-facebook-f (just the f that many folks like)
fa-facebook-square (the version with the more rounded corners)

I’ll do this with Pinterest, too.

There will be a massive overhaul of how social icons are done in 5.0.

@tagliala
Copy link
Member

@davegandy

This one has always bugged me. In 4.3, we’ll have 3 versions:
fa-facebook (official)
fa-facebook-f (just the f that many folks like)

You can't do this in 4.3, it will break backward compatibility

Please use another name for the official facebook logo, then we will fix things in 5.0.0 :)

@athyuttamre
Copy link

Yay, awesome! Thanks @davegandy and @tagliala. Looking forward to the changes.

@tagliala tagliala added this to the 4.3.0 milestone Dec 12, 2014
@tagliala
Copy link
Member

Refers to #1966

@davegandy take also a look at #2197, it's quite popular and it is about the same topic

@davegandy
Copy link
Member

Updated in 4.3.0-wip.

  • fa-facebook now points to facebook official
  • fa-facebook-f has been added as an icon
  • fa-pinterest-p has been added as an icon

Closing.

@tagliala
Copy link
Member

@davegandy this breaks backward compatibility.

We should not do this in 4.3 and delay to 5.0.0

my suggestion

  • alias fa-facebook to fa-facebook-f
  • add fa-facebook-official

when 5.0.0 will be released, we can rename fa-facebook-alias to fa-facebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants