-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Facebook & Pinterest logos #4463
Comments
@tylertrotter this is for uniformity with other squared icons in FA |
@tagliala This violates brand guidelines though. If we're not using the right Facebook logo, it looks rather unpolished. Would be really nice to use the right one. Thoughts? Here's the brand guideline: www.facebookbrand.com. |
This one has always bugged me. In 4.3, we’ll have 3 versions: I’ll do this with Pinterest, too. There will be a massive overhaul of how social icons are done in 5.0. |
You can't do this in 4.3, it will break backward compatibility Please use another name for the official facebook logo, then we will fix things in 5.0.0 :) |
Yay, awesome! Thanks @davegandy and @tagliala. Looking forward to the changes. |
Refers to #1966 @davegandy take also a look at #2197, it's quite popular and it is about the same topic |
Updated in 4.3.0-wip.
Closing. |
@davegandy this breaks backward compatibility. We should not do this in 4.3 and delay to 5.0.0 my suggestion
when 5.0.0 will be released, we can rename fa-facebook-alias to fa-facebook |
In the attached image I've set a Font Awesome Facebook icon (left) next to one I pulled from Facebook's website (right). You can see that the rounded corners and proportions of the square are both off.
The text was updated successfully, but these errors were encountered: