Issue 610: Prevent swipe logic from taking over when no swipe was made #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -561,7 +563,7 @@ export default class Carousel extends React.Component { | |||
| this.previousSlide(); | |||
| } | |||
| } | |||
| } else { | |||
| } else if (touchLength > 0) { | |||
There was a problem hiding this comment.
Super small fix, just making sure when a touch happens, it has some distance before we trigger the goToSlide to slide back to the currentSlide.
|
works like a charm! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents swipe logic from running when a swipe of 0 distance (meaning just tapping the screen) has occurred.
Fixes #610
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Existing tests pass. Manually tested.
Screenshots
The little numbered button under each slide is a button within the carousel that changes the
slideIndexon click, before they didn't work (on emulated mobile), now they do: