Issue 611: Added extra props to allow customization of default controls #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31addf7 to
bcd6e65
Compare
bcd6e65 to
5deb130
Compare
sarmeyer
reviewed
Jan 28, 2020
| cx="3" | ||
| cy="3" | ||
| r="3" | ||
| style={{ |
There was a problem hiding this comment.
Yes, thank you for moving this to the buttonStyles!
sarmeyer
approved these changes
Jan 28, 2020
frnk94
pushed a commit
to frnk94/nuka-carousel
that referenced
this pull request
Jan 31, 2020
frnk94
pushed a commit
to frnk94/nuka-carousel
that referenced
this pull request
Jan 31, 2020
frnk94
pushed a commit
to frnk94/nuka-carousel
that referenced
this pull request
Jan 31, 2020
frnk94
pushed a commit
to frnk94/nuka-carousel
that referenced
this pull request
Jan 31, 2020
frnk94
pushed a commit
to frnk94/nuka-carousel
that referenced
this pull request
Jan 31, 2020
sarmeyer
pushed a commit
that referenced
this pull request
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds extra props to let users customize Nuka's default controls.
NOTE: I did not implement the ability to swap out the text of the Next/Prev button for icons or components. A custom icon would also need to support hover effects, enable/disable, and maybe other functionality that, I felt, could introduce too many edge cases. If a user wants totally special Next/Prev buttons, then, I feel, it's best to simply pass in their own custom component and handle all the logic themselves.
Fixes #611
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Manually tested, and current tests pass.
Screenshots
Normal demo app, without any changes (meaning things keep working by default):
Shnazzy demo app with custom text for Prev/Next buttons and red paging dots:
