Issue 494: Updated scroll transition logic to fix wrapAround flash #635
Conversation
3c3733b to
c64ebbf
Compare
| }, | ||
| () => { | ||
| stateCb(); | ||
| this.setLeft(); |
There was a problem hiding this comment.
Removing the call to setLeft and the updates to left and top from the method setDimensions fixed the wrap around problem we saw when heightMode was set to current.
I beliiieeeeve (but I'm not positive), that these extra calls to set the left and top, were simply ways to ensure that the carousel wouldn't flash. But, I think the new wrapAround logic should prevent it sooooooooo... I don't think we need these calls. I've been playing around with the demo a bit and it all still works.
However, if you notice new bugs coming from these removal of these lines, I can put them back in and try and fix the wraparound problem when heightMode is current in another PR.
| @@ -15,6 +15,7 @@ class App extends React.Component { | |||
| underlineHeader: false, | |||
| zoomScale: 0.5, | |||
| slidesToShow: 1, | |||
| slidesToScroll: 1, | |||
There was a problem hiding this comment.
Added this to state in our demo app so we can easier update this param when testing.
…d better distribute slides
c64ebbf to
e9c959b
Compare
Description
This PR updates the
scroll-transitionlogic to remove the wrapAround flash. It divides up the available slides to be in-front and in-back of the carousel (taking into account, alignment and slides to show) so flipping through slides shouldn't flash (as much...).Fixes #494, #606
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Passes all written tests, and lots of manual testing.
Screenshots
Normal wrap around:
Partial wrap around:
Height Mode "current" wrap around:
Extreme wrap around. Slides to show is 6, slides to scroll is 2, and there are only 6 slides in total 😱 (still manages to "work" as best it can):
