Extracted fields for delegates in BindCallbacks #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the GC is not aware that the extern calls hold reference to passed delegates, it will collect these delegates which will result in some nasty exceptions※. To prevent this, I have extracted the delegates as fields, which will be tied to the lifetime of the NativeWindow object (making sure the GC does not collect them before collecting the NativeWindow object).
※: I was getting ExecutionEngineException on .NET Core and CallbackOnCollectedDelegate on .NET Framework on calls to Glfw.PollEvents.
I have tested that my code works with builds of glfw-net that include this change and the problem has not come back.
Note: I had missed SetErrorCallback the first time around.