Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow Flaggable type constraint #132

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Narrow Flaggable type constraint #132

merged 1 commit into from
Jan 21, 2025

Conversation

FollowTheProcess
Copy link
Owner

Summary

@FollowTheProcess FollowTheProcess added the refactoring Refactoring label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.88%. Comparing base (827d625) to head (f751ee3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/flag.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   91.91%   91.88%   -0.03%     
==========================================
  Files           6        6              
  Lines        1348     1344       -4     
==========================================
- Hits         1239     1235       -4     
  Misses         77       77              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FollowTheProcess FollowTheProcess merged commit 1fcb29b into main Jan 21, 2025
10 of 12 checks passed
@FollowTheProcess FollowTheProcess deleted the feat/more-types branch January 21, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant