Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit SFX and Edit Music Object Support #31

Closed
guighub opened this issue Dec 25, 2023 · 7 comments
Closed

Edit SFX and Edit Music Object Support #31

guighub opened this issue Dec 25, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@guighub
Copy link

guighub commented Dec 25, 2023

Is your feature request related to a problem? Please describe.
I'm currently working on a MIDI importer for Geometry Dash that imports each note as a sound effect with a set pitch and volume, and I need a way to stop the note with an "Edit SFX" object after the MIDI note ends.

Describe the solution you'd like
Edit Music and Edit SFX objects similar to the SfxTrigger() object in the current API.

Describe alternatives you've considered
I tried toggling the SFX object on or off with a Toggle trigger object but I don't think it affects the sound.

Additional context
No additional context that I know of.

@guighub guighub added the enhancement New feature or request label Dec 25, 2023
@Folleach
Copy link
Owner

Folleach commented Dec 25, 2023

Thank you for request.
I'll go add Edit Song Trigger (that's what it's called in the game) and Edit Sfx Trigger

I tried toggling the SFX object on or off with a Toggle trigger object but I don't think it affects the sound.

You're right, toggle trigger is just used to activate some trigger, no more

Folleach added a commit that referenced this issue Dec 25, 2023
Folleach added a commit that referenced this issue Dec 25, 2023
@Folleach
Copy link
Owner

Folleach commented Dec 25, 2023

I've done :)
EditSfxTrigger and EditSongTrigger released in v0.2.23

Your project is interesting.
I'd like to take a look at your project, when you're done, will you share it?

@ascpixi
Copy link
Contributor

ascpixi commented Dec 26, 2023

@Folleach Hi! I'm also interested in SFX trigger functionality. It seems like the SFXGroup member is missing from SfxTrigger. It is present in EditSfxTrigger, so I'm not sure if this is an oversight. Thanks in advance!

image

@guighub
Copy link
Author

guighub commented Dec 26, 2023

I've done :) EditSfxTrigger and EditSongTrigger released in v0.2.23

Your project is interesting. I'd like to take a look at your project, when you're done, will you share it?

Thank you so much! And yes, when the project is mostly complete I plan to make a repo for it.

@ascpixi
Copy link
Contributor

ascpixi commented Dec 26, 2023

@Folleach Hi! I'm also interested in SFX trigger functionality. It seems like the SFXGroup member is missing from SfxTrigger. It is present in EditSfxTrigger, so I'm not sure if this is an oversight. Thanks in advance!

I have implemented this in pull request #32. @Folleach

@Folleach
Copy link
Owner

@ascpixi oh... Wow. Thank you! I didn't notice that the trigger has other pages at first, hah

I've review and merge your pull request #32
Now I should add other missing properties, then I'll create a new release

@Folleach
Copy link
Owner

So, it seems I've added properties from all pages.
You can use it in the version 0.2.24

Thank you very much! Have a good day ^_^
If you have any more questions, feel free to ask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants