Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs native API with promises #1243

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Use fs native API with promises #1243

merged 2 commits into from
Dec 12, 2023

Conversation

LoicPoullain
Copy link
Member

Issue

Some old code has been promisified in order to work with NodeJS API. In latest versions of Node, async functions are natively available with promises. Foal should use these functions directly instead.

Solution and steps

  • Use node:fs/promises

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain merged commit 6db23d2 into 4-3-0 Dec 12, 2023
2 checks passed
@LoicPoullain LoicPoullain deleted the promise-native-api branch December 12, 2023 21:13
@LoicPoullain LoicPoullain mentioned this pull request Dec 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant