Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better log socket.io events #1240

Merged
merged 13 commits into from
Oct 29, 2023
Merged

Better log socket.io events #1240

merged 13 commits into from
Oct 29, 2023

Conversation

LoicPoullain
Copy link
Member

@LoicPoullain LoicPoullain commented Oct 28, 2023 •
edited
Loading

Issue

The new logging system introduced in v4.1 enhances logging of HTTP requests. It does not handle socket.io events.

Solution and steps

  • Update Logger.
  • Update SocketIOController.

Checklist

  • Add/update/check docs (code comments and docs/ folder).
  • Add/update/check tests.
  • Update/check the cli generators.

@LoicPoullain LoicPoullain changed the base branch from master to v4-2-0 October 28, 2023 17:34
@LoicPoullain LoicPoullain mentioned this pull request Oct 28, 2023
Merged
4 tasks
@LoicPoullain LoicPoullain merged commit e46740b into v4-2-0 Oct 29, 2023
2 checks passed
@LoicPoullain LoicPoullain deleted the logs-socket.io branch October 29, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Issue tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LoicPoullain