Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added C wrapper generator #56

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Added C wrapper generator #56

merged 9 commits into from
Aug 11, 2023

Conversation

stemann
Copy link
Collaborator

@stemann stemann commented Dec 5, 2022 •
edited
Loading

Added OCaml-based wrapper generator.

Contributes to resolution of #54

PR Checklist

  • Tests are added N/A
  • Documentation, if applicable

@stemann stemann force-pushed the stemann/build_wrapper branch from 9ed413c to 0cd8f46 Compare December 5, 2022 15:23
@stemann stemann force-pushed the stemann/build_wrapper branch 5 times, most recently from ba63e93 to d1fb8e6 Compare December 18, 2022 13:02
@stemann stemann force-pushed the stemann/build_wrapper branch 2 times, most recently from 81b79ad to 60690d6 Compare May 6, 2023 09:51
@stemann stemann force-pushed the stemann/build_wrapper branch from 60690d6 to cff0cd7 Compare August 2, 2023 10:08
@stemann stemann changed the title Update wrapper for Torch v1.10 Added C wrapper generator Aug 2, 2023
@stemann
Copy link
Collaborator Author

stemann commented Aug 2, 2023

Slimmed this PR down to just adding the OCaml-based C wrapper generator - will follow up with PR updating C wrapper for Torch 1.10 (for a start) - based on the ocaml-torch wrapper generator as mentioned in JuliaPackaging/Yggdrasil#6004 (comment)

@stemann stemann marked this pull request as ready for review August 2, 2023 10:14
@stemann stemann mentioned this pull request Aug 2, 2023
Closed
@stemann stemann force-pushed the stemann/build_wrapper branch 4 times, most recently from 22b1853 to 820bd6e Compare August 2, 2023 13:11
@stemann stemann marked this pull request as draft August 2, 2023 13:27
@stemann stemann marked this pull request as ready for review August 2, 2023 13:27
@stemann
Copy link
Collaborator Author

stemann commented Aug 8, 2023 •
edited
Loading

@DhairyaLGandhi @ToucheSir This should be ready for review when you have time - as a step to getting a new version of Torch.jl ready (with the already built Torch_jll v1.10.2).

ToucheSir
ToucheSir reviewed Aug 8, 2023
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@stemann stemann force-pushed the stemann/build_wrapper branch from 8bdb2d1 to b754398 Compare August 9, 2023 07:33
@stemann stemann force-pushed the stemann/build_wrapper branch from b754398 to 15942a0 Compare August 9, 2023 07:35
ToucheSir
ToucheSir approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMK if you still have anything to add, otherwise will merge first thing tomorrow

@stemann
Copy link
Collaborator Author

stemann commented Aug 11, 2023

LMK if you still have anything to add, otherwise will merge first thing tomorrow

Nothing more at this point.

@ToucheSir ToucheSir merged commit 638d1bd into FluxML:master Aug 11, 2023
@stemann stemann deleted the stemann/build_wrapper branch August 11, 2023 14:11
@stemann stemann mentioned this pull request Aug 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToucheSir ToucheSir ToucheSir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stemann @ToucheSir