Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load Yota at all #166

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Don't load Yota at all #166

merged 8 commits into from
Feb 6, 2024

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Feb 2, 2024

No description provided.

@mcabbott mcabbott changed the title Don't load Yota at all on Julia 1.9+ Don't load Yota at all Feb 5, 2024
@mcabbott
Copy link
Member Author

mcabbott commented Feb 5, 2024

Paging @dfdx -- what's the status of Yota on latest Julia? Should we hold out for a fix here?

@dfdx
Copy link

dfdx commented Feb 5, 2024

It can be fixed (see dfdx/Umlaut.jl#55 for the main required change), but I'm not sure Optimisers should depend on Yota at the moment. Yota is on hold until better times. Specifically, until more wide ecosystem for deep learning is available, so quite indefinite time. Till then, Optimisers may benefit more from a shorter list of more actively developed packages.

Yet, if you believe Yota will bring some unique benefits, please ping me and I will gladly update the package.

@mcabbott mcabbott mentioned this pull request Feb 6, 2024
2 tasks
@mcabbott
Copy link
Member Author

mcabbott commented Feb 6, 2024

Certainly no pressure to work harder for the sake of this package! Just thought I shouldn't cut this without checking in.

We all had hopes that several AD packages might be viable at the same time, but remain stuck on Zygote...

@mcabbott mcabbott merged commit 6473c45 into master Feb 6, 2024
3 of 4 checks passed
@mcabbott mcabbott deleted the mcabbott-patch-3 branch February 6, 2024 21:12
mashu pushed a commit to mashu/Optimisers.jl that referenced this pull request Nov 14, 2024
* Update runtests.jl

* Update runtests.jl

* Update Project.toml

* Update runtests.jl

* Update rules.jl

* Update destructure.jl

* test is no longer broken

* Update index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants