Bring mutating optimisations back #13
Closed
+186
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darsnack
reviewed
Mar 11, 2021
Co-authored-by: Kyle Daruwalla <daruwalla.k.public@icloud.com>
darsnack
reviewed
Mar 12, 2021
|
@DhairyaLGandhi I have rebased this locally, do you mind if I push it? |
|
I think I wanted to handle this separately. It also seems like some other changes were merged hastily? |
|
What do you mean handled separately? This has been in need of a rebase for months (any recent changes weren't the reason for preventing this from being merged). |
|
Mutation isn't the goal - so Handling the code duplication separately. Mutation should not be the default unless it is absolutely needed. The api change also needs to be accounted for. |
|
I am confused. Do you still want to merge this PR or not? All I want is to merge this PR. |
|
We can merge it when we need it. We'd prolly not make mutation the default though. |
|
Superseded by #31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.