Skip to content

Commit

Permalink
using effect_set = std::vector<effect*>
Browse files Browse the repository at this point in the history
  • Loading branch information
@salix5
salix5 committed Feb 7, 2025
1 parent 6812551 commit 0e599a0
Show file tree
Hide file tree
Showing 7 changed files with 50 additions and 142 deletions.
64 changes: 32 additions & 32 deletions card.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ uint32_t card::get_code() {
temp.code = code;
filter_effect(EFFECT_CHANGE_CODE, &effects);
if (effects.size())
code = effects.get_last()->get_value(this);
code = effects.back()->get_value(this);
temp.code = UINT32_MAX;
return code;
}
Expand All @@ -450,7 +450,7 @@ uint32_t card::get_another_code() {
filter_effect(EFFECT_ADD_CODE, &eset);
if(!eset.size())
return code2;
uint32_t otcode = eset.get_last()->get_value(this);
uint32_t otcode = eset.back()->get_value(this);
if(code1 != otcode)
return otcode;
return 0;
Expand Down Expand Up @@ -642,7 +642,7 @@ std::pair<int32_t, int32_t> card::get_base_atk_def() {
filter_effect(EFFECT_SET_BASE_DEFENSE, &eset, FALSE);
filter_effect(EFFECT_SET_BASE_DEFENSE_FINAL, &eset, FALSE);
}
eset.sort();
std::sort(eset.begin(), eset.end(), effect_sort_id);
// calculate single effects of this first
for(int32_t i = 0; i < eset.size();) {
if (eset[i]->type & EFFECT_TYPE_SINGLE) {
Expand All @@ -652,14 +652,14 @@ std::pair<int32_t, int32_t> card::get_base_atk_def() {
if(batk < 0)
batk = 0;
temp.base_attack = batk;
eset.remove_item(i);
eset.erase(eset.begin() + i);
continue;
case EFFECT_SET_BASE_DEFENSE:
bdef = eset[i]->get_value(this);
if(bdef < 0)
bdef = 0;
temp.base_defense = bdef;
eset.remove_item(i);
eset.erase(eset.begin() + i);
continue;
}
}
Expand Down Expand Up @@ -746,7 +746,7 @@ std::pair<int32_t, int32_t> card::get_atk_def() {
filter_effect(EFFECT_SET_DEFENSE, &eset, FALSE);
filter_effect(EFFECT_SET_DEFENSE_FINAL, &eset, FALSE);
}
eset.sort();
std::sort(eset.begin(), eset.end(), effect_sort_id);
bool rev = false;
if (is_affected_by_effect(EFFECT_REVERSE_UPDATE))
rev = true;
Expand All @@ -758,14 +758,14 @@ std::pair<int32_t, int32_t> card::get_atk_def() {
if (atk < 0)
atk = 0;
temp.attack = atk;
eset.remove_item(i);
eset.erase(eset.begin() + i);
continue;
case EFFECT_SET_DEFENSE:
def = eset[i]->get_value(this);
if (def < 0)
def = 0;
temp.defense = def;
eset.remove_item(i);
eset.erase(eset.begin() + i);
continue;
}
}
Expand All @@ -775,7 +775,7 @@ std::pair<int32_t, int32_t> card::get_atk_def() {
switch (eset[i]->code) {
case EFFECT_UPDATE_ATTACK:
if (eset[i]->is_flag(EFFECT_FLAG2_REPEAT_UPDATE))
effects_repeat_update_atk.add_item(eset[i]);
effects_repeat_update_atk.push_back(eset[i]);
else if ((eset[i]->type & EFFECT_TYPE_SINGLE) && !eset[i]->is_flag(EFFECT_FLAG_SINGLE_RANGE))
up_atk += eset[i]->get_value(this);
else
Expand All @@ -796,19 +796,19 @@ std::pair<int32_t, int32_t> card::get_atk_def() {
upc_atk = 0;
}
else if (eset[i]->is_flag(EFFECT_FLAG2_OPTION)) {
effects_atk_option.add_item(eset[i]);
effects_atk_option.push_back(eset[i]);
}
else if (eset[i]->is_flag(EFFECT_FLAG2_WICKED)) {
effects_atk_wicked.add_item(eset[i]);
effects_atk_wicked.push_back(eset[i]);
}
else {
effects_atk_final.add_item(eset[i]);
effects_atk_final.push_back(eset[i]);
}
break;
// def
case EFFECT_UPDATE_DEFENSE:
if (eset[i]->is_flag(EFFECT_FLAG2_REPEAT_UPDATE))
effects_repeat_update_def.add_item(eset[i]);
effects_repeat_update_def.push_back(eset[i]);
else if ((eset[i]->type & EFFECT_TYPE_SINGLE) && !eset[i]->is_flag(EFFECT_FLAG_SINGLE_RANGE))
up_def += eset[i]->get_value(this);
else
Expand All @@ -829,13 +829,13 @@ std::pair<int32_t, int32_t> card::get_atk_def() {
upc_def = 0;
}
else if (eset[i]->is_flag(EFFECT_FLAG2_OPTION)) {
effects_def_option.add_item(eset[i]);
effects_def_option.push_back(eset[i]);
}
else if (eset[i]->is_flag(EFFECT_FLAG2_WICKED)) {
effects_def_wicked.add_item(eset[i]);
effects_def_wicked.push_back(eset[i]);
}
else {
effects_def_final.add_item(eset[i]);
effects_def_final.push_back(eset[i]);
}
break;
case EFFECT_SWAP_AD:
Expand Down Expand Up @@ -927,7 +927,7 @@ int32_t card::get_battle_attack() {
effect_set eset;
filter_effect(EFFECT_SET_BATTLE_ATTACK, &eset);
if (eset.size()) {
int32_t atk = eset.get_last()->get_value(this);
int32_t atk = eset.back()->get_value(this);
if (atk < 0)
atk = 0;
return atk;
Expand All @@ -939,7 +939,7 @@ int32_t card::get_battle_defense() {
effect_set eset;
filter_effect(EFFECT_SET_BATTLE_DEFENSE, &eset);
if (eset.size()) {
int32_t def = eset.get_last()->get_value(this);
int32_t def = eset.back()->get_value(this);
if (def < 0)
def = 0;
return def;
Expand Down Expand Up @@ -2200,7 +2200,7 @@ std::tuple<uint8_t, effect*> card::refresh_control_status() {
effect_set eset;
filter_effect(EFFECT_SET_CONTROL, &eset);
if(eset.size()) {
effect* peffect = eset.get_last();
effect* peffect = eset.back();
if(peffect->id >= last_id) {
final = (uint8_t)peffect->get_value(this);
ceffect = peffect;
Expand Down Expand Up @@ -2339,7 +2339,7 @@ int32_t card::add_counter(uint8_t playerid, uint16_t countertype, uint16_t count
int32_t limit = 0;
filter_effect(EFFECT_COUNTER_LIMIT + cttype, &eset);
if (eset.size())
limit = eset.get_last()->get_value();
limit = eset.back()->get_value();
if(limit) {
int32_t mcount = limit - get_counter(cttype);
if (mcount < 0)
Expand Down Expand Up @@ -2409,7 +2409,7 @@ int32_t card::is_can_add_counter(uint8_t playerid, uint16_t countertype, uint16_
cur = cmit->second;
filter_effect(EFFECT_COUNTER_LIMIT + countertype, &eset);
if (eset.size())
limit = eset.get_last()->get_value();
limit = eset.back()->get_value();
if(limit > 0 && (cur + (singly ? 1 : count) > limit))
return FALSE;
return TRUE;
Expand Down Expand Up @@ -2596,7 +2596,7 @@ void card::filter_effect_container(const effect_container& container, uint32_t c
auto rg = container.equal_range(code);
for (auto it = rg.first; it != rg.second; ++it) {
if (f(this, it->second))
eset.add_item(it->second);
eset.push_back(it->second);
}
}
void card::filter_effect_container(const effect_container& container, uint32_t code, effect_filter f, effect_collection& eset) {
Expand All @@ -2616,7 +2616,7 @@ void card::filter_effect(uint32_t code, effect_set* eset, uint8_t sort) {
filter_effect_container(pcard->xmaterial_effect, code, default_xmaterial_filter, *eset);
filter_effect_container(pduel->game_field->effects.aura_effect, code, default_aura_filter, *eset);
if(sort)
eset->sort();
std::sort(eset->begin(), eset->end(), effect_sort_id);
}
void card::filter_single_continuous_effect(uint32_t code, effect_set* eset, uint8_t sort) {
filter_effect_container(single_effect, code, accept_filter, *eset);
Expand All @@ -2633,7 +2633,7 @@ void card::filter_single_continuous_effect(uint32_t code, effect_set* eset, uint
for (auto& pcard : xyz_materials)
filter_effect_container(pcard->xmaterial_effect, code, xmaterial_filter, *eset);
if(sort)
eset->sort();
std::sort(eset->begin(), eset->end(), effect_sort_id);
}
void card::filter_self_effect(uint32_t code, effect_set* eset, uint8_t sort) {
auto single_filter = [](card* c, effect* peffect) -> bool {
Expand All @@ -2646,7 +2646,7 @@ void card::filter_self_effect(uint32_t code, effect_set* eset, uint8_t sort) {
for (auto& pcard : xyz_materials)
filter_effect_container(pcard->xmaterial_effect, code, xmaterial_filter, *eset);
if (sort)
eset->sort();
std::sort(eset->begin(), eset->end(), effect_sort_id);
}
// refresh this->immune_effect
void card::filter_immune_effect() {
Expand All @@ -2665,7 +2665,7 @@ void card::filter_immune_effect() {
for (auto& pcard : xyz_materials)
filter_effect_container(pcard->xmaterial_effect, EFFECT_IMMUNE_EFFECT, xmaterial_filter, immune_effect);
filter_effect_container(pduel->game_field->effects.aura_effect, EFFECT_IMMUNE_EFFECT, target_filter, immune_effect);
immune_effect.sort();
std::sort(immune_effect.begin(), immune_effect.end(), effect_sort_id);
}
// for all disable-related peffect of this,
// 1. Insert all cards in the target of peffect into effects.disable_check_list.
Expand Down Expand Up @@ -2700,7 +2700,7 @@ int32_t card::filter_summon_procedure(uint8_t playerid, effect_set* peset, uint8
if(eset.size()) {
for(int32_t i = 0; i < eset.size(); ++i) {
if(check_summon_procedure(eset[i], playerid, ignore_count, min_tribute, zone))
peset->add_item(eset[i]);
peset->push_back(eset[i]);
}
if(peset->size())
return -1;
Expand All @@ -2710,7 +2710,7 @@ int32_t card::filter_summon_procedure(uint8_t playerid, effect_set* peset, uint8
filter_effect(EFFECT_SUMMON_PROC, &eset);
for(int32_t i = 0; i < eset.size(); ++i) {
if(check_summon_procedure(eset[i], playerid, ignore_count, min_tribute, zone))
peset->add_item(eset[i]);
peset->push_back(eset[i]);
}
// ordinary summon
if(!pduel->game_field->is_player_can_summon(SUMMON_TYPE_NORMAL, playerid, this, playerid))
Expand Down Expand Up @@ -2786,7 +2786,7 @@ int32_t card::filter_set_procedure(uint8_t playerid, effect_set* peset, uint8_t
if(eset.size()) {
for(int32_t i = 0; i < eset.size(); ++i) {
if(check_set_procedure(eset[i], playerid, ignore_count, min_tribute, zone))
peset->add_item(eset[i]);
peset->push_back(eset[i]);
}
if(peset->size())
return -1;
Expand All @@ -2796,7 +2796,7 @@ int32_t card::filter_set_procedure(uint8_t playerid, effect_set* peset, uint8_t
filter_effect(EFFECT_SET_PROC, &eset);
for(int32_t i = 0; i < eset.size(); ++i) {
if(check_set_procedure(eset[i], playerid, ignore_count, min_tribute, zone))
peset->add_item(eset[i]);
peset->push_back(eset[i]);
}
if(!pduel->game_field->is_player_can_mset(SUMMON_TYPE_NORMAL, playerid, this, playerid))
return FALSE;
Expand Down Expand Up @@ -2883,7 +2883,7 @@ void card::filter_spsummon_procedure(uint8_t playerid, effect_set* peset, uint32
uint32_t sumtype = peffect->get_value(this);
if((!summon_type || summon_type == sumtype)
&& pduel->game_field->is_player_can_spsummon(sumeffect, sumtype, topos, playerid, toplayer, this))
peset->add_item(peffect);
peset->push_back(peffect);
}
}
}
Expand All @@ -2903,7 +2903,7 @@ void card::filter_spsummon_procedure_g(uint8_t playerid, effect_set* peset) {
pduel->lua->add_param(peffect, PARAM_TYPE_EFFECT);
pduel->lua->add_param(this, PARAM_TYPE_CARD);
if(pduel->lua->check_condition(peffect->condition, 2))
peset->add_item(peffect);
peset->push_back(peffect);
pduel->game_field->restore_lp_cost();
pduel->game_field->core.reason_effect = oreason;
pduel->game_field->core.reason_player = op;
Expand Down
2 changes: 1 addition & 1 deletion effect.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ int32_t effect::get_required_handorset_effects(effect_set* eset, uint8_t playeri
pduel->lua->add_param(this, PARAM_TYPE_EFFECT);
if(pduel->lua->check_condition(peffect->cost, 10)) {
available = 2;
eset->add_item(peffect);
eset->push_back(peffect);
}
}
}
Expand Down
2 changes: 0 additions & 2 deletions effect.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ class duel;
class group;
class effect;
struct tevent;
struct effect_set;
struct effect_set_v;
enum effect_flag : uint64_t;
enum effect_flag2 : uint64_t;
enum effect_category :uint64_t;
Expand Down
94 changes: 2 additions & 92 deletions effectset.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,104 +8,14 @@
#ifndef EFFECTSET_H_
#define EFFECTSET_H_

#include <array>
#include <vector>
#include <algorithm>

class effect;

bool effect_sort_id(const effect* e1, const effect* e2);

// std::array<effect*, 64>
struct effect_set {
void add_item(effect* peffect) {
if (count >= 64)
return;
container[count++] = peffect;
}
void remove_item(int index) {
if (index < 0 || index >= count)
return;
for(int i = index; i < count - 1; ++i)
container[i] = container[i + 1];
--count;
}
void clear() {
count = 0;
}
int size() const {
return count;
}
void sort() {
if(count < 2)
return;
std::sort(container.begin(), container.begin() + count, effect_sort_id);
}
effect* const& get_last() const {
assert(count);
return container[count - 1];
}
effect*& get_last() {
assert(count);
return container[count - 1];
}
effect* const& operator[] (int index) const {
return container[index];
}
effect*& operator[] (int index) {
return container[index];
}
effect* const& at(int index) const {
return container[index];
}
effect*& at(int index) {
return container[index];
}
private:
std::array<effect*, 64> container{ nullptr };
int count{ 0 };
};

struct effect_set_v {
void add_item(effect* peffect) {
container.push_back(peffect);
}
void remove_item(int index) {
if (index < 0 || index >= (int)container.size())
return;
container.erase(container.begin() + index);
}
void clear() {
container.clear();
}
int size() const {
return (int)container.size();
}
void sort() {
std::sort(container.begin(), container.end(), effect_sort_id);
}
effect* const& get_last() const {
assert(container.size());
return container.back();
}
effect*& get_last() {
assert(container.size());
return container.back();
}
effect* const& operator[] (int index) const {
return container[index];
}
effect*& operator[] (int index) {
return container[index];
}
effect* const& at(int index) const {
return container[index];
}
effect*& at(int index) {
return container[index];
}
private:
std::vector<effect*> container;
};
using effect_set = std::vector<effect*>;
using effect_set_v = effect_set;

#endif //EFFECTSET_H_
Loading

0 comments on commit 0e599a0

Please sign in to comment.