Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5020 Fix: cc and bcc ui issue #5932

Merged
merged 2 commits into from
Feb 13, 2025
Merged

#5020 Fix: cc and bcc ui issue #5932

merged 2 commits into from
Feb 13, 2025

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Feb 10, 2025

This PR fixed cc and bcc ui issue

close #5020 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review February 10, 2025 13:16
@ioanmo226 ioanmo226 requested a review from sosnovsky as a code owner February 10, 2025 13:16
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but I noticed a minor issue:

  • enter to, cc and bcc recipients
  • switch to message text input
  • switch back to recipients input
  • in this PR an empty non-clickable space is added after cc recipient

master:
Screenshot 2025-02-11 at 12 55 44

this PR:
Screenshot 2025-02-11 at 12 54 08

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well now 👍

@sosnovsky sosnovsky merged commit 116ae48 into master Feb 13, 2025
12 checks passed
@sosnovsky sosnovsky deleted the 5020-cc-and-bcc-ui-issue branch February 13, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CC and BCC UI issue
2 participants