-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4607 look up users on LDAP explicitly using a ldap-relay API #4627
Conversation
@tomholub With current implementation, Settings/attester page shows this error. |
buggy endpoint, that was supposed to be a 404 Please treat error 500 as error 404 on this particular endpoint - meaning no pubkeys found. Meanwhile I've filed an issue to improve the endpoint https://github.com/FlowCrypt/flowcrypt-attester-ts/issues/264 (you won't see it but it will eventually get fixed) |
Got it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - see comments
This PR looks up users on LDAP explicitly using a ldap-relay API
close #4607 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):