Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem in opening links to an external browser #1726

Open
martgil opened this issue Mar 30, 2022 · 8 comments
Open

problem in opening links to an external browser #1726

martgil opened this issue Mar 30, 2022 · 8 comments
Assignees
Labels
Milestone

Comments

@martgil
Copy link
Collaborator

martgil commented Mar 30, 2022

Description:

A user reported to us that an email contains links that are not clickable from the FlowCrypt app. I don't see quite a difference between the links that work and links that don't work.

I've investigated the issue and confirmed that certain links are indeed not invoking the default browser when the link is clicked.

The email came from kraken.com's new device login approval but I believe it would be more of a general issue.

Steps to replicate the issue:
(pre-requisite: kraken account) - https://www.kraken.com/en-us/sign-in
tested on: FlowCrypt android app v1.3.0

  1. Let's assume that you've already have an account at kraken.com
  2. trigger the 'new device login approval' email by logging in your account through their android app (https://play.google.com/store/apps/details?id=com.kraken.invest.app)
  3. an email will be sent to your address containing the confirmation email for new device approval.
  4. the 'approve device' text is rendered as a hyperlink but clicking so will do just nothing.

To save some time in replicating the issue, I'll send a sample email that produces the said problem. (email subject contains the github issue number)

Reference:https://mail.google.com/mail/u/6/#search/new+device+approval/FMfcgzGmvfTwXrhLMxSbswdbmLCpnZTr

@DenBond7 DenBond7 self-assigned this Mar 30, 2022
@DenBond7 DenBond7 added this to the soon milestone Mar 30, 2022
@DenBond7 DenBond7 added the bug label Apr 14, 2022
@DenBond7
Copy link
Collaborator

Hi @martgil. It's a little strange. I can open this link.

image

Could you re-check the current issue?

@martgil
Copy link
Collaborator Author

martgil commented Apr 19, 2022

@DenBond7 It's strange. I can open the link now, too.

Thanks for looking into this - I'll close the issue for now and update the user to check if it is now working on their end.

I'll just re-open the issue or create a new one if the issue persists. Thank you!

@martgil martgil closed this as completed Apr 19, 2022
@martgil
Copy link
Collaborator Author

martgil commented Apr 20, 2022

The user responded and confirmed that it is now working fine :D Thanks again!

@martgil
Copy link
Collaborator Author

martgil commented Feb 10, 2023

We received another complaint about this issue where the approval link from kraken cannot be opened -- it only happens only for that particular link as other links can be opened. According to the user's email, nothing happens when they clicked the approval link.

I tested this on my emulator and on my device but I'm not able to reproduce the problem on my end. I have saved a test email from my kraken login attempt for my account and extracted the mime message so it would be easy for us to test it on flowcrypt android app (subject: flowcrypt-android issue #1726): https://mail.google.com/mail/u/flowcrypt.compatibility@gmail.com/#inbox/FMfcgzGrcXmqCRDmHFSQfXfnjVkxhvrL

What we have tried so far is to update the Android System WebView but that doesn't help.

ref: https://mail.google.com/mail/u/human@flowcrypt.com/#inbox/FMfcgzGrcXlhvgxhnMGWXxKTMxvdtkDq

@FlowCrypt FlowCrypt deleted a comment from github-actions bot Feb 10, 2023
@DenBond7 DenBond7 modified the milestones: Discussion, 1.4.2 Feb 10, 2023
@FlowCrypt FlowCrypt deleted a comment from github-actions bot Feb 14, 2023
@DenBond7 DenBond7 modified the milestones: 1.4.2, 1.4.3 Feb 27, 2023
@DenBond7
Copy link
Collaborator

@martgil Sorry for the delayed reply. I still can't reproduce it. Please look at the video(I've sent it via email. It contains sensitive info). Maybe I do something wrong.

@DenBond7 DenBond7 modified the milestones: 1.4.3, 1.4.4 Mar 30, 2023
@martgil
Copy link
Collaborator Author

martgil commented Mar 30, 2023

Thank you for looking into the other case. I have watched the video you've shared -- I'm getting the same result. I'll send a follow-up with the reporting user to see if the issue still exists in version 1.4.2.

@martgil martgil changed the title potential problem in rendering links problem in opening links to an external browser Apr 3, 2023
@DenBond7 DenBond7 modified the milestones: 1.4.4, 1.5.0 Apr 20, 2023
@DenBond7 DenBond7 modified the milestones: 1.5.0, 1.5.1 Dec 18, 2023
@DenBond7 DenBond7 modified the milestones: 1.5.1, 1.5.2, 1.5.3 Jan 3, 2024
@DenBond7 DenBond7 modified the milestones: 1.5.3, 1.5.4 Jan 24, 2024
@DenBond7
Copy link
Collaborator

I'm closing it for now

@DenBond7 DenBond7 modified the milestones: 1.5.4, Discussion Jan 31, 2024
@martgil martgil reopened this Dec 14, 2024
@martgil
Copy link
Collaborator Author

martgil commented Dec 14, 2024

Hello @DenBond7, we received a report again regarding this matter again. The bug description is still the same where tapping onto the link do no open the page on a browser.

I've tested it as well and still do not work on mine. I remember we tested this before and we got positive result though.

I have imported the test email to flowcrypt.compatibility account where its the same exact email i have recieved from Kraken - https://mail.google.com/mail/u/flowcrypt.compatibility@gmail.com/#inbox/FMfcgzQXKhJZwCKcZhPbthvsxScLZjnJ.
The test email is the newer one with subject "Welcome to Kraken".

I'll be sending the screen recording once again, im using my email so I had to send it via secure corporate email.

Clicking the link on FlowCrypt browser extension works well.

@FlowCrypt FlowCrypt deleted a comment from github-actions bot Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants