Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content waves notebooks (Ch 2) and cookbook #43

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Conversation

ChristiaanDHoogervorst
Copy link
Collaborator

No description provided.

Copy link
Owner

@FlorisCalkoen FlorisCalkoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristiaanDHoogervorst, thank you for the PR and the work!

One small request, would you mind keeping the filenaming patterns consistent, i.e., all lower case and seperated by underscore (_) instead of hyphens? For example, notebooks/week_3-Answered.ipynb to notebooks/week_3_answered.ipynb and Week_3_Initalize.ipynb to week_3_initialize.ipynb?

Also, in the long run I think we should keep the answers in a different repository so that the students will not have access to the answers. We can, for example, fork this repository as a private repository and keep the filled in notebooks in that place. What do you think?

@ChristiaanDHoogervorst
Copy link
Collaborator Author

I agree with the naming, I didn't pay much attention to that as it was for personal use when I started this journey. Let's discuss the second part through Teams or in person, as we agreed on in the last group meeting.

I want to push the cookbook to main to make sure everyone uses the latest version when developing questions.

CDH-TUD and others added 2 commits January 18, 2024 17:42
Om de antwoorden niet op Git Hub te krijgen is het bestand verwijderd
@FlorisCalkoen FlorisCalkoen changed the title week 3, cookbook and minor changes Content waves notebooks (Ch 2) and cookbook Jan 19, 2024
@FlorisCalkoen FlorisCalkoen merged commit 3273a36 into main Jan 19, 2024
2 checks passed
@FlorisCalkoen FlorisCalkoen deleted the Chris-update branch January 19, 2024 17:14
@ChristiaanDHoogervorst
Copy link
Collaborator Author

The notebook of week 3 has been renamed to week 2, even though this was described in the file name and heading of the notebook. I don't know what else has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants