-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add icons support in notes #273
Conversation
Code looks good! Well done 🚀 I've just got some clarification questions:
|
Thanks!
|
|
Here is what I did in my last push:
Emojis have to be searched during Suggestion in this format I took the stand of not parsing complete emojis shortcodes in the Markdown Post Processor as I believe emojis use case will be to autocomplete them entirely with the EditorSuggestor, that way they will be replaced in every view as their unicodes counterpart. |
I think suggesting emojis below icons is fine. Looks good to me, I'll merge this PR now. I am still adjusting some minor things when the PR is merged. Thank you for the work! |
This PR aims to add support for icons inside Notes content.
Follows up with #148 feature request.
Two main elements have been added:
main.ts - Markdown processor for icon shortcodes in notes with no performance impact
:RiHeartsFill:
when they are found in Notes.fill:"currentColor"
in the svg tag.icon.getIconByName()
.iconSuggestion.ts - EditorSuggest for icons autocompletion
getAllLoadedIconNames()
fromiconPackManager.ts
.All modifications are mobile proof and works on mobile and tablet devices.
Let me know if you have any question or idea to improve!