Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing API entries on the wrappers #262

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Missing API entries on the wrappers #262

merged 9 commits into from
Oct 24, 2024

Conversation

sanguinariojoe
Copy link
Collaborator

Just a couple of API entries that were missing on the wrappers. Notes:

  • I compiled Python and Fortran. Can anybody try to compile the matlab one?
  • I did not check any of them (related: Test the wrappers #203)

@sanguinariojoe sanguinariojoe self-assigned this Oct 21, 2024
@RyanDavies19
Copy link
Collaborator

@sanguinariojoe after fixing the two redefinition errors Matlab compiled fine for me! (MacOS, Apple Silicon, MATLAB 24.1.0.2628055)

@sanguinariojoe
Copy link
Collaborator Author

@sanguinariojoe after fixing the two redefinition errors Matlab compiled fine for me! (MacOS, Apple Silicon, MATLAB 24.1.0.2628055)

I do not have MATLAB logs (because I have not MATLAB). What are the errors?

@RyanDavies19
Copy link
Collaborator

They're clang errors, not Matlab.

MoorDyn/wrappers/matlab/MoorDynM_Serialize.cpp:46:12: error: redefinition of 'err'
MoorDyn/wrappers/matlab/MoorDynM_GetTimeScheme.cpp:46:12: error: redefinition of 'err'

@sanguinariojoe
Copy link
Collaborator Author

They're clang errors, not Matlab.

MoorDyn/wrappers/matlab/MoorDynM_Serialize.cpp:46:12: error: redefinition of 'err' MoorDyn/wrappers/matlab/MoorDynM_GetTimeScheme.cpp:46:12: error: redefinition of 'err'

Thanks! It should work fine now

This was referenced Oct 23, 2024
Closed
Closed
RyanDavies19
RyanDavies19 requested changes Oct 23, 2024
View reviewed changes
wrappers/matlab/MoorDynM_GetTimeScheme.cpp Outdated
{
int err;
size_t name_len;
int err = MoorDyn_GetTimeScheme(instance, NULL, &name_len);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here (line 44) and line 47 still have a redefinition of err. Need to remove the int declaration

@RyanDavies19
Copy link
Collaborator

@sanguinariojoe I think you forgot to get rid of the int declaration in GetTimeScheme, its still throwing the compile errors. I flagged it with a comment.

Other than that it looks good!

@sanguinariojoe
Copy link
Collaborator Author

@sanguinariojoe I think you forgot to get rid of the int declaration in GetTimeScheme, its still throwing the compile errors. I flagged it with a comment.

Other than that it looks good!

Geez! I am becoming dumber and dumber...

@sanguinariojoe sanguinariojoe merged commit 0cb7979 into FloatingArrayDesign:dev Oct 24, 2024
7 checks passed
@RyanDavies19
Copy link
Collaborator

@sanguinariojoe I think you forgot to get rid of the int declaration in GetTimeScheme, its still throwing the compile errors. I flagged it with a comment.
Other than that it looks good!

Geez! I am becoming dumber and dumber...

Hahaha, thanks for doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanDavies19 RyanDavies19 RyanDavies19 requested changes

Assignees

@sanguinariojoe sanguinariojoe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanguinariojoe @RyanDavies19