Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indexable object types #80

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Fix indexable object types #80

merged 2 commits into from
Feb 24, 2022

Conversation

Flipez
Copy link
Owner

@Flipez Flipez commented Feb 11, 2022

No description provided.

@vercel
Copy link

vercel bot commented Feb 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/flipez/rocket-lang/HCP7uqLp5QFw9Ac1DY1guzfgPHuN
✅ Preview: https://rocket-lang-git-fix-indexable-object-types-flipez.vercel.app

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #80 (7c7cfbf) into master (320f0e7) will increase coverage by 0.75%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   82.85%   83.61%   +0.75%     
==========================================
  Files          89       89              
  Lines        2502     2697     +195     
==========================================
+ Hits         2073     2255     +182     
- Misses        368      376       +8     
- Partials       61       66       +5     
Impacted Files Coverage Δ
ast/assign.go 85.71% <ø> (ø)
ast/index.go 45.45% <0.00%> (-45.46%) ⬇️
evaluator/evaluator.go 77.10% <50.00%> (-3.30%) ⬇️
parser/index.go 75.67% <77.77%> (+5.67%) ⬆️
evaluator/assign.go 100.00% <100.00%> (ø)
evaluator/index.go 100.00% <100.00%> (+28.88%) ⬆️
parser/assign.go 69.23% <100.00%> (+5.59%) ⬆️
parser/expression.go 82.00% <100.00%> (+2.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 320f0e7...7c7cfbf. Read the comment docs.

Signed-off-by: Flipez <code@brauser.io>
@Flipez Flipez marked this pull request as ready for review February 24, 2022 21:40
@Flipez Flipez merged commit 0900363 into master Feb 24, 2022
@Flipez Flipez deleted the fix-indexable-object-types branch February 24, 2022 21:40
@Flipez Flipez mentioned this pull request Feb 26, 2022
@Flipez Flipez linked an issue Feb 26, 2022 that may be closed by this pull request
@Flipez Flipez restored the fix-indexable-object-types branch April 23, 2022 09:28
@Flipez Flipez deleted the fix-indexable-object-types branch April 23, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix indexing
2 participants