Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[object/string] Add support for HASH and ARRAY to .format() #148

Merged
merged 3 commits into from
Nov 1, 2022
Merged

[object/string] Add support for HASH and ARRAY to .format() #148

merged 3 commits into from
Nov 1, 2022

Conversation

MarkusFreitag
Copy link
Collaborator

No description provided.

@MarkusFreitag MarkusFreitag requested a review from Flipez as a code owner November 1, 2022 17:30
@vercel
Copy link

vercel bot commented Nov 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rocket-lang ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 7:50PM (UTC)
rocket-lang-play ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 7:50PM (UTC)

@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #148 (e3141f5) into main (db13aa7) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
+ Coverage   87.52%   87.58%   +0.06%     
==========================================
  Files         106      106              
  Lines        3703     3721      +18     
==========================================
+ Hits         3241     3259      +18     
  Misses        396      396              
  Partials       66       66
Impacted Files Coverage Δ
object/object.go 91.43% <100.00%> (+0.92%) ⬆️
object/string.go 98.17% <100.00%> (-0.08%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@MarkusFreitag MarkusFreitag force-pushed the string-format-array-hash-support branch from 23e76c5 to dae8dbb Compare November 1, 2022 17:44
@MarkusFreitag MarkusFreitag force-pushed the string-format-array-hash-support branch from dae8dbb to 0e2e06a Compare November 1, 2022 18:05
@MarkusFreitag
Copy link
Collaborator Author

ready to merge

@Flipez
Copy link
Owner

Flipez commented Nov 1, 2022

:shipit:

@Flipez Flipez changed the title String format array hash support [object/string] Add support for HASH and ARRAY to .format() Nov 1, 2022
@Flipez Flipez added the enhancement New feature or request label Nov 1, 2022
@Flipez Flipez merged commit 827267b into main Nov 1, 2022
@Flipez Flipez deleted the string-format-array-hash-support branch November 1, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flipez Flipez Flipez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkusFreitag @Flipez