Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for the reporting tutorial #4

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

victorgarcia98
Copy link
Contributor

This PR adds 4 images: one for the headroom sensor and 3 for the profit sensors for the process under the three different policies.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, much better :) ..

One small note for your consideration: it might be more intuitive to a reader to see the chart showing costs rather than losses. In the sense that a consumption process is expected to cost something, but not lead to a loss. It's just a matter of making the example click to a first-time reader. I feel the underlying reporter is named correctly, but we could consider renaming these sensors to "Costs (Breakable)", etc.

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 2448d21 into main Aug 24, 2023
@Flix6x Flix6x deleted the reporting-tutorial branch August 25, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants