db: improve belief search with new index #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Flix6x
reviewed
Feb 28, 2024
flexmeasures/data/migrations/versions/977f366a62df_add_quad_search_index_for_beliefs.py
Outdated
Show resolved
Hide resolved
flexmeasures/data/migrations/versions/977f366a62df_add_quad_search_index_for_beliefs.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
|
The more crucial reason to depend on a higher timely-beliefs version is SeitaBV/timely-beliefs#166 That one gets more bang for the buck. We should merge both for a new version, if possible. |
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
|
@Flix6x Will you add the minimum timely-beliefs version in this PR when preparing a (dev/patch?) release? |
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Flix6x
added a commit
that referenced
this pull request
Mar 1, 2024
* make upgrading removing-obsolete-tables migration more stable Signed-off-by: Nicolas Höning <nicolas@seita.nl> * re-do migration, as we do not add the UNIQUE index after all Signed-off-by: Nicolas Höning <nicolas@seita.nl> * remove alembic comments Signed-off-by: Nicolas Höning <nicolas@seita.nl> * re-do migration based on changes in TB#167 Signed-off-by: Nicolas Höning <nicolas@seita.nl> * chore: upgrade minimum requirement Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: F.N. Claessen <felix@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading beliefs takes too long. Next to a subquery improvement in timely-beliefs, we can also add an index on the 4 fields which usually are part of the queries. PR TB#167 makes sure a db migration catches the new index.
This PR includes this migration for FlexMeasures.
Look & Feel
flexmeasures db upgradeHow to test
In this PR I describe a small script to test the speedup (between before and after this migration).
I actually did not see a giant speedup, when the subquery optimization from TB#166 is already there. Without it, it can do a 50% improvement.