inflexible devices power unit conversion #968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
Flix6x
reviewed
Feb 1, 2024
| @@ -208,6 +209,8 @@ def get_power_values( | |||
| ) | |||
| df = df.fillna(0) | |||
|
|
|||
| df *= convert_units(1, sensor.unit, to_unit) | |||
There was a problem hiding this comment.
I think if you pass df instead of 1 this method may even allow converting from kWh to kW using the sensor's resolution.
2 tasks
|
Requesting a status update:
|
To be closed as it's been replaced by #1007.
Yes, #1007 improves on the tests.
No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description