Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unable to click child assets table #1029

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: unable to click child assets table #1029

merged 1 commit into from
Apr 5, 2024

Conversation

victorgarcia98
Copy link
Contributor

Important

This was introduced in v0.20.0 so we need to backport to v0.20.1.

Description

Lately, I found that I couldn't click the child assets table rows to go to the their asset page.

image

How to test

  • Go to the asset page of an Asset with children and click one of the rows to go to the its asset page.
  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
fix: add a column header to child assets table to match the number of…
21d1f77 
… columns

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 requested a review from Flix6x April 4, 2024 08:21
@victorgarcia98 victorgarcia98 self-assigned this Apr 4, 2024
@Flix6x Flix6x modified the milestones: 0.20.1, 0.21.0 Apr 4, 2024
Flix6x
Flix6x approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! However, the bug was not introduced in v0.20, but in #941. Since that feature is still unreleased, this PR requires no backport or changelog.

@victorgarcia98 victorgarcia98 merged commit f5077fe into main Apr 5, 2024
13 of 14 checks passed
@victorgarcia98 victorgarcia98 deleted the fix/ui/unable-to-click-child-assets-table branch April 5, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
UI
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgarcia98 @Flix6x