-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Return transient traits explicitly #4375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Issue related to the REST API
feature
New feature or request
labels
Jul 23, 2024
Docker builds report
|
Uffizzi Preview |
khvn26
force-pushed
the
feat/return-transient-traits
branch
from
July 23, 2024 19:44
9d3f9e0
to
d7a44a2
Compare
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Jul 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 1165 1165
Lines 38508 38525 +17
=======================================
+ Hits 37281 37298 +17
Misses 1227 1227 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Jul 23, 2024
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Jul 24, 2024
matthewelwell
approved these changes
Jul 24, 2024
github-actions
bot
added
feature
New feature or request
and removed
feature
New feature or request
labels
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
As discussed offline, this makes the
/api/v1/identities
SDK route return transient traits explicitly. This helps simplify SDK caching logic — i.e. see this commit to JS SDK.Contributes to #4278.
How did you test this code?
Modified an existing unit test.