Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return transient traits explicitly #4375

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

As discussed offline, this makes the /api/v1/identities SDK route return transient traits explicitly. This helps simplify SDK caching logic — i.e. see this commit to JS SDK.

Contributes to #4278.

How did you test this code?

Modified an existing unit test.

@khvn26 khvn26 requested a review from novakzaballa July 23, 2024 18:59
@khvn26 khvn26 requested a review from a team as a code owner July 23, 2024 18:59
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:49am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:49am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 9:49am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4375 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4375 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4375 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4375 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4375 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4375 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 23, 2024

Uffizzi Preview deployment-54537 was deleted.

@khvn26 khvn26 force-pushed the feat/return-transient-traits branch from 9d3f9e0 to d7a44a2 Compare July 23, 2024 19:44
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (f1cc8d8) to head (e3371b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4375   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files        1165     1165           
  Lines       38508    38525   +17     
=======================================
+ Hits        37281    37298   +17     
  Misses       1227     1227           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 23, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 24, 2024
@khvn26 khvn26 requested a review from matthewelwell July 24, 2024 09:44
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 24, 2024
@khvn26 khvn26 added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 79b3ae7 Jul 24, 2024
32 checks passed
@khvn26 khvn26 deleted the feat/return-transient-traits branch July 24, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants