Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(master-api-key/roles): Add roles to master api key #2436

Merged
merged 33 commits into from
Aug 25, 2023

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Jul 14, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?

Changes

  • Adds authentication class for master API key
  • Remove master API key middleware
  • Remove master API key specific permissions
  • Add roles support to master API key

New endpoint:

[GET/PUT/DELETE/POST] /api/v1/organisations/{organisation_pk}/roles/{role_pk}/master-api-keys/

How did you test this code?

Covered by unit tests

@vercel
Copy link

vercel bot commented Jul 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 4:07pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 4:07pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 4:07pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/2436

⚙️ Updating now by workflow run 5966124279.

What is Uffizzi? Learn more!

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

Codecov Report

Patch coverage: 93.25% and project coverage change: -0.01% ⚠️

Comparison is base (81d5396) 95.47% compared to head (1f9f9bc) 95.46%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2436      +/-   ##
==========================================
- Coverage   95.47%   95.46%   -0.01%     
==========================================
  Files         982      986       +4     
  Lines       27558    27689     +131     
==========================================
+ Hits        26310    26434     +124     
- Misses       1248     1255       +7     
Files Changed Coverage Δ
api/app/settings/common.py 87.71% <ø> (ø)
api/environments/permissions/permissions.py 74.11% <ø> (-2.30%) ⬇️
api/features/tests/test_views.py 100.00% <ø> (ø)
api/organisations/urls.py 74.35% <0.00%> (-1.96%) ⬇️
api/projects/permissions.py 88.00% <ø> (-3.75%) ⬇️
...integration/environments/test_clone_environment.py 100.00% <ø> (ø)
...turestate/test_environment_featurestate_viewset.py 100.00% <ø> (ø)
...s/featurestate/test_simple_featurestate_viewset.py 100.00% <ø> (ø)
...ures/multivariate/test_integration_multivariate.py 100.00% <ø> (ø)
...pi/tests/unit/features/test_unit_features_views.py 100.00% <ø> (ø)
... and 37 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the github label Aug 4, 2023
.github/workflows/api-deploy-production-ecs.yml Outdated Show resolved Hide resolved
api/core/models.py Outdated Show resolved Hide resolved
api/environments/views.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the github label Aug 23, 2023
api/conftest.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Token Management
3 participants