Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some renames to types that were incorrect. #2986

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

ewoutkramer
Copy link
Member

@ewoutkramer ewoutkramer commented Dec 3, 2024

The codegen had some code to keep on generating divergent names for enums, components, types etcetera, which were once generated in error but that we could not correct until we are publishing a new major release. Now is the time.

This PR contains the result of re-running codegen with some of the improved names for the types.

⚠️ Also review FirelyTeam/fhir-codegen#48

Breaking changes

  • Narrative.div and Narrative.status are no longer in-summary (this has been corrected in later versions of the spec, but was not yet reflected in the generated code). This will result in a different rendering of resources when generating summaries!\
  • CitedArtifactContributorshipSummaryComponent has been renamed to the more correct ContributorshipSummaryComponent.

@mmsmits mmsmits self-requested a review December 5, 2024 09:12
@mmsmits mmsmits enabled auto-merge December 5, 2024 09:31
@mmsmits mmsmits merged commit fcfb244 into develop-6.0 Dec 5, 2024
16 checks passed
@mmsmits mmsmits deleted the 6.0/run-improved-codegen branch December 5, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants