Draft of a new PocoElementNode instead of IScopedNode #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Hl7.Fhir.Base/Model/Base.TypedElement.cs # src/Hl7.Fhir.ElementModel.Shared.Tests/ScopedNodeOnBaseTests.cs
ewoutkramer
requested changes
Dec 2, 2024
ewoutkramer
requested changes
Dec 2, 2024
src/Hl7.Fhir.ElementModel.Shared.Tests/ScopedNodeOnBaseTests.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Shims.STU3AndUp/ElementModel/TypedElementExtensions.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Specification.Shared.Tests/Snapshot/SnapshotGeneratorManifestTests.cs
Outdated
Show resolved
Hide resolved
src/Hl7.Fhir.Support.Poco.Tests/Model/TypedElementToPocoTests.cs
Outdated
Show resolved
Hide resolved
ewoutkramer
requested changes
Dec 2, 2024
… base class for simplicity
…' into spike/implement-new-pocoElemNode
ewoutkramer
requested changes
Dec 3, 2024
ewoutkramer
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Designed and implemented a new Poco element node as the solution to our weakly typed IScopednode (which was more of an issue than we thought)
Related issues
#2894
Testing
ToTypedElement() now uses this implementation. the tests run.