Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes issue #2860. #2861

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Closes issue #2860. #2861

merged 2 commits into from
Sep 12, 2024

Conversation

mexvod
Copy link
Contributor

@mexvod mexvod commented Sep 11, 2024

Related issues

Closes [issue #2860].

@mmsmits
Copy link
Member

mmsmits commented Sep 12, 2024

Thanks for your PR! Really appreciate it. Can you maybe also add a unit test?

@mexvod
Copy link
Contributor Author

mexvod commented Sep 12, 2024

Thanks for your PR! Really appreciate it. Can you maybe also add a unit test?

Ok. I can try. But I can't understand the project structure for tests.

@mexvod
Copy link
Contributor Author

mexvod commented Sep 12, 2024

Thanks for your PR! Really appreciate it. Can you maybe also add a unit test?

I created tests

@mmsmits mmsmits merged commit f5422cc into FirelyTeam:develop Sep 12, 2024
14 checks passed
@mmsmits
Copy link
Member

mmsmits commented Sep 12, 2024

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants