FS location issue fix #2831
Merged
FS location issue fix #2831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lements on source nodes to have a location decided by their XML parent's structure, even if that is not a resource?
alexzautke
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the location issue that FS was encountering. A source node with contained FHIR resources will now include the non-FHIR structures around the resources in the source node locations. I am not sure if this is the behaviour we should be having, but it does meet FS expectations, and since we decided to assume that location is not important for implementations, we should adjust it to allow FS to upgrade
Related issues
Closes #2784 (again)
Testing
Tested using the FS test base (dotnet pack then import into a fork of their code base)