Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement of invariants ref-1, sdf-24 and sdf-25 [STU3] #2195

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Improvement of invariants ref-1, sdf-24 and sdf-25 [STU3] #2195

merged 2 commits into from
Aug 11, 2022

Conversation

marcovisserFurore
Copy link
Member

Description

Improvement of the following invariants:

  • ref-1
  • sdf-24
  • sdf-25

And add an unit test to prove it.

Related issues

Resolves #2153

Testing

See BasicValidationTests.InvariantValidation

FirelyTeam Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Mark the PR with the label breaking change when this PR introduces breaking changes

@marcovisserFurore marcovisserFurore marked this pull request as draft August 11, 2022 07:19
@marcovisserFurore marcovisserFurore marked this pull request as ready for review August 11, 2022 09:31
@mmsmits mmsmits merged commit d129c98 into develop-stu3 Aug 11, 2022
@mmsmits mmsmits deleted the feature/2153-improved-constraints branch August 11, 2022 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmsmits mmsmits mmsmits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manually correct Invariants ref-1, sdf-24 and sdf-25
2 participants
@marcovisserFurore @mmsmits