Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not dispose of a shared HttpMessageHandler passed into the constructor #2040

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

brianpos
Copy link
Collaborator

Description

When creating the new HttpClient inside the constructor indicate that if it is a shared MessageHandler and therefore that it should not be disposing it when it is finished with it.
As the change in the common lib has a default parameter this is not a truly breaking change, and in the R4 (version level) functionality the public surface has not changed this is not tagged as a breaking change.

Related issues

Resolves [issue #2029].

Testing

The unit test CallsCallbacksHttpClient was used to verify this functionality, as it fails when the fix is not applied.

…sion that includes the default parameter for the disposeHandler (even though we pass it throuth)
@marcovisserFurore marcovisserFurore changed the base branch from develop-r4 to develop-stu3 April 20, 2022 11:42
@marcovisserFurore marcovisserFurore changed the base branch from develop-stu3 to develop-r4 April 20, 2022 11:42
Copy link
Member

@marcovisserFurore marcovisserFurore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also make a PR for develop-stu3

@brianpos
Copy link
Collaborator Author

This also requires that common layer change to be merged in too - just reminding.

@marcovisserFurore marcovisserFurore merged commit 7dbec45 into develop-r4 Apr 20, 2022
@marcovisserFurore marcovisserFurore deleted the feature/BP-2029 branch April 20, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants