master branch not saving hasMany relationship

[sir-dunxalot]

I have a hasMany relationship on a model:

// models/feature.js

export default DS.Model.extend({
  stages: DS.hasMany('stage', {
    async: true
  }),
});

// models/stage.js
export default DS.Model.extend({
  feature: DS.belongsTo('feature', {
    async: true
  }),
});

I am creating stages and setting them on a feature. The stages array exists on the feature client-side. However, it is not persisted to the Firebase DB.

This is how I am saving the models:

  save() {
    this.get('model').save().then(function(feature) {
      feature.get('stages').forEach(function(stage) {
        stage.save();
      });
    });
  },

Here is how the feature model appears in the Firebase DB:

One would expect an array of stages to be persisted to the feature model.

The stage model persists as expected:

Is there something obviously wrong here or could this be a bug on master branch?

• Ember 1.13.2
• Ember Data 1.13.5
• Emberfire master branch

[tmayr]

Having the same issues, seems like updateRecords isnt serializing the records properly.

Might be related to emberjs/data#3550 ?

[tstirrat]

Thanks for the report, will do some testing and work out what's wrong.

[sir-dunxalot]

Thanks, Tim. Also, to confirm the error is not existent with Ember fire 1.4.7 and ED beta.18.

[tstirrat]

ok, I figured out what this is.

It's ember-data JSONSerializer's _shouldSerializeHasMany returns false on manyToOne relationships

i.e. when a hasMany has a companion belongsTo relationship the JSONSerializer prefers to only save the belongsTo side.

[sir-dunxalot]

Thanks for looking into it, Tim. is there something we should do in apps to mitigate this or is it likely to be solved by either ED or Emberfire in an upcoming release?

[tstirrat]

I have a fix ready, just creating a breaking test to ensure this issue doesn't pop up again.

[tstirrat]

Let me know if an updated master fixes your issue.

Reopen this issue if you still have problems :)

[sir-dunxalot]

Looks like that fixed it. Thanks a lot!